From b61c886c23ca1e7b6885a200a786e722241a98c6 Mon Sep 17 00:00:00 2001 From: Mike Kell Date: Sat, 30 May 2026 10:53:00 -0400 Subject: [PATCH] chore: remove 8 unnecessary_import directives and 1 unused variable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - feature_wordpress/test: removed 8 unnecessary_import directives across 5 test files (barrel exports already cover these symbols) - kell_mobile/test: removed unused productCards local variable - dart analyze --fatal-infos now passes clean across all packages - All 410 tests still pass (311 feature_wordpress, 14 kell_mobile, 24 kell_web, 41 design_system, 20 core) - Updated build_execution_tracker.md (Stage 7A → merged) - Updated master_development_brief.md (next branch, validation state) --- docs/development/build_execution_tracker.md | 30 +++++++++++++++---- docs/development/master_development_brief.md | 7 +++-- .../apps/kell_mobile/test/widget_test.dart | 2 -- .../product_publishing_controller_test.dart | 3 -- .../test/widgets/product_draft_card_test.dart | 1 - .../widgets/product_preview_panel_test.dart | 1 - .../widgets/publish_status_chip_test.dart | 1 - .../widgets/status_action_snack_bar_test.dart | 2 -- 8 files changed, 29 insertions(+), 18 deletions(-) diff --git a/docs/development/build_execution_tracker.md b/docs/development/build_execution_tracker.md index 9d1429f..0af6c38 100644 --- a/docs/development/build_execution_tracker.md +++ b/docs/development/build_execution_tracker.md @@ -2,9 +2,9 @@ ## Current status -- main baseline updated through: bulk-status-actions (Stage 7A in progress) -- next branch: feat/bulk-status-actions (Stage 7A) -- current stage: Stage 7A — Bulk Status Actions +- main baseline updated through: bulk-status-actions (Stage 7A complete) +- next branch: feat/bulk-operator-workflows (Stage 7B) or feat/integrations-contracts (Stage 8A) +- current stage: Stage 7A complete — deciding next slice ## Slice tracker @@ -228,7 +228,8 @@ ### feat/bulk-status-actions -- status: ready for merge +- status: merged to main +- commit: `2c3ed3b` - date: 2026-05-30 - inspection: complete - implementation: complete @@ -239,4 +240,23 @@ - `feature_wordpress/test/product_publishing_controller_test.dart` — added 11 new `bulkUpdateStatus` tests: no-op on empty selection, moves all to draft, sets result on all-success, clears multi-selection, clears updatingIds, handles mixed statuses, consume clears result, starts null, preserves preview selection, persists filter/sort, disposal safety - tests: passed (311/311 feature_wordpress, 24/24 kell_web — 335+ total) - analyze: passed (info-level only — 8 pre-existing unnecessary_import in test files) -- brief updated: pending +- brief updated: yes + +### chore/analyze-cleanup-and-tracker-sync + +- status: in progress +- date: 2026-05-30 +- inspection: complete +- implementation: complete +- files changed: + - `feature_wordpress/test/product_publishing_controller_test.dart` — removed 3 unnecessary_import directives (get_product_drafts, product_publishing_controller, publish_product) + - `feature_wordpress/test/widgets/product_draft_card_test.dart` — removed 1 unnecessary_import directive (product_draft_card) + - `feature_wordpress/test/widgets/product_preview_panel_test.dart` — removed 1 unnecessary_import directive (product_preview_panel) + - `feature_wordpress/test/widgets/publish_status_chip_test.dart` — removed 1 unnecessary_import directive (publish_status_chip) + - `feature_wordpress/test/widgets/status_action_snack_bar_test.dart` — removed 2 unnecessary_import directives (product_publishing_controller, status_action_snack_bar) + - `kell_mobile/test/widget_test.dart` — removed unused `productCards` local variable + - `docs/development/build_execution_tracker.md` — updated Stage 7A to merged, synced current status + - `docs/development/master_development_brief.md` — updated next recommended branch, validation state, test counts +- tests: passed (311/311 feature_wordpress, 14/14 kell_mobile, 24/24 kell_web, 41/41 design_system, 20/20 core — 410 total) +- analyze: passed (dart analyze --fatal-infos — no issues found across all packages) +- brief updated: yes diff --git a/docs/development/master_development_brief.md b/docs/development/master_development_brief.md index 3f43c5a..287dcc3 100644 --- a/docs/development/master_development_brief.md +++ b/docs/development/master_development_brief.md @@ -133,7 +133,8 @@ Rules: - latest reported count for `feature_wordpress`: `311/311 passed` - latest reported count for `kell_web`: `24/24 passed` - latest reported count for `kell_mobile`: `14/14 passed` -- baseline commit: merge of `feat/android-mobile-ux-hardening` (2026-05-30) +- total: `410/410 passed` +- baseline commit: merge of `feat/bulk-status-actions` + analyze cleanup (2026-05-30) #### Baseline test coverage (established 2026-05-22) @@ -149,8 +150,8 @@ No minimum thresholds are enforced — this is visibility-only tracking. Coverag ### Next recommended branch -**`feat/bulk-status-actions`** — Stage 7: Controlled bulk actions. -Branch from latest `main`. All entry criteria met: single-item edit/status flows stable, multi-select groundwork complete, post-write consistency hardened, Android core publishing surface exists. Stage 6 (Android operational maturity) is complete. +**`feat/bulk-operator-workflows`** — Stage 7B: Additional bulk actions (bulk publish, bulk move to pending review), or **`feat/integrations-contracts`** — Stage 8A: Integration abstractions. +Branch from latest `main`. Stage 7A (bulk move-to-draft) is complete. Stage 7B adds incremental bulk actions. Stage 8A begins infrastructure activation required for all subsequent feature work (Stages 9–16). --- diff --git a/kell_creations_apps/apps/kell_mobile/test/widget_test.dart b/kell_creations_apps/apps/kell_mobile/test/widget_test.dart index 97ca760..c6aa1b9 100644 --- a/kell_creations_apps/apps/kell_mobile/test/widget_test.dart +++ b/kell_creations_apps/apps/kell_mobile/test/widget_test.dart @@ -141,8 +141,6 @@ void main() { final cards = find.byType(GestureDetector); expect(cards, findsWidgets); - // Find any product card and tap it - final productCards = find.byType(SizedBox); // Tap on the first product in the list view final firstProduct = find.byWidgetPredicate( (widget) => widget is SizedBox && widget.height == 72 && widget.child != null, diff --git a/kell_creations_apps/packages/feature_wordpress/test/product_publishing_controller_test.dart b/kell_creations_apps/packages/feature_wordpress/test/product_publishing_controller_test.dart index 7e2e301..45b266a 100644 --- a/kell_creations_apps/packages/feature_wordpress/test/product_publishing_controller_test.dart +++ b/kell_creations_apps/packages/feature_wordpress/test/product_publishing_controller_test.dart @@ -1,9 +1,6 @@ import 'package:flutter_test/flutter_test.dart'; import 'package:feature_wordpress/feature_wordpress.dart'; -import 'package:feature_wordpress/src/application/get_product_drafts.dart'; -import 'package:feature_wordpress/src/application/product_publishing_controller.dart'; -import 'package:feature_wordpress/src/application/publish_product.dart'; void main() { late FakeProductPublishingRepository repository; diff --git a/kell_creations_apps/packages/feature_wordpress/test/widgets/product_draft_card_test.dart b/kell_creations_apps/packages/feature_wordpress/test/widgets/product_draft_card_test.dart index 600b684..4abbcc1 100644 --- a/kell_creations_apps/packages/feature_wordpress/test/widgets/product_draft_card_test.dart +++ b/kell_creations_apps/packages/feature_wordpress/test/widgets/product_draft_card_test.dart @@ -3,7 +3,6 @@ import 'package:flutter/material.dart'; import 'package:flutter_test/flutter_test.dart'; import 'package:feature_wordpress/feature_wordpress.dart'; -import 'package:feature_wordpress/src/presentation/widgets/product_draft_card.dart'; void main() { final sampleDraft = ProductDraft( diff --git a/kell_creations_apps/packages/feature_wordpress/test/widgets/product_preview_panel_test.dart b/kell_creations_apps/packages/feature_wordpress/test/widgets/product_preview_panel_test.dart index 9d92bc0..cb3afcb 100644 --- a/kell_creations_apps/packages/feature_wordpress/test/widgets/product_preview_panel_test.dart +++ b/kell_creations_apps/packages/feature_wordpress/test/widgets/product_preview_panel_test.dart @@ -3,7 +3,6 @@ import 'package:flutter/material.dart'; import 'package:flutter_test/flutter_test.dart'; import 'package:feature_wordpress/feature_wordpress.dart'; -import 'package:feature_wordpress/src/presentation/widgets/product_preview_panel.dart'; void main() { final sampleDraft = ProductDraft( diff --git a/kell_creations_apps/packages/feature_wordpress/test/widgets/publish_status_chip_test.dart b/kell_creations_apps/packages/feature_wordpress/test/widgets/publish_status_chip_test.dart index 794f5ec..bac3a81 100644 --- a/kell_creations_apps/packages/feature_wordpress/test/widgets/publish_status_chip_test.dart +++ b/kell_creations_apps/packages/feature_wordpress/test/widgets/publish_status_chip_test.dart @@ -3,7 +3,6 @@ import 'package:flutter/material.dart'; import 'package:flutter_test/flutter_test.dart'; import 'package:feature_wordpress/feature_wordpress.dart'; -import 'package:feature_wordpress/src/presentation/widgets/publish_status_chip.dart'; void main() { Widget buildTestWidget(PublishStatus status) { diff --git a/kell_creations_apps/packages/feature_wordpress/test/widgets/status_action_snack_bar_test.dart b/kell_creations_apps/packages/feature_wordpress/test/widgets/status_action_snack_bar_test.dart index 4aa622d..f9ff713 100644 --- a/kell_creations_apps/packages/feature_wordpress/test/widgets/status_action_snack_bar_test.dart +++ b/kell_creations_apps/packages/feature_wordpress/test/widgets/status_action_snack_bar_test.dart @@ -3,8 +3,6 @@ import 'package:flutter/material.dart'; import 'package:flutter_test/flutter_test.dart'; import 'package:feature_wordpress/feature_wordpress.dart'; -import 'package:feature_wordpress/src/application/product_publishing_controller.dart'; -import 'package:feature_wordpress/src/presentation/widgets/status_action_snack_bar.dart'; void main() { group('showStatusActionSnackBar', () {